【Hackathon 9th No.69】add test_draft_model_preprocess #3832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
freeliuzc
reviewed
Sep 4, 2025
| np.testing.assert_allclose( | ||
| results["seq_lens_this_time"], np.array([40, 62, 31, 66, 90, 1, 5, 24, 40, 69], dtype="int32") | ||
| ) | ||
| np.testing.assert_allclose(results["accept_tokens"][0][0:4], np.array([12, 16, 12, 22])) |
There was a problem hiding this comment.
这里变量都用 rand + 固定 seed 的方式产出，最后根据 random 的值校对结果，逻辑有点怪；
期望两种方式：
1.[Best] 使用 python 组网复现 GPU Kernel 逻辑，校对两者结果
2.手动设置部分有意义的值，并手动推算出正确结果，作为单测
freeliuzc
approved these changes
Sep 8, 2025
|
Great Work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加单测 test_draft_model_preprocess