Skip to content

Fixes to Chapter Six compilation issues #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes to Chapter Six compilation issues #3

wants to merge 3 commits into from

Conversation

@MBounouar
Copy link

@MBounouar MBounouar commented Aug 27, 2022

  • bumping up PyO3 to version 0.16.6 fixes compilation issues
  • Removed duplicate import and missing pub mod import
  • Fixed some warning by passing the ? operator

@maxwellflitton
Copy link
Collaborator

maxwellflitton commented Sep 28, 2022

@MBounouar thank you for adding this it is a create help

@MBounouar
Copy link
Author

MBounouar commented Sep 29, 2022

@MBounouar thank you for adding this it is a create help

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MBounouar @maxwellflitton