Skip to content

Fix type hints in Chapter02/testing/test_model_performance.py #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nimanzik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix type hints in Chapter02/testing/test_model_performance.py #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions Chapter02/testing/test_model_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import pytest
import numpy as np
from typing import Union
import sklearn
from sklearn.ensemble import RandomForestClassifier
from sklearn.datasets import load_wine
from sklearn.model_selection import train_test_split
Expand All @@ -11,7 +9,7 @@
import joblib

@pytest.fixture
def test_dataset() -> Union[np.array, np.array]:
def test_dataset() -> tuple[np.array, np.array]:
# Load the dataset
X, y = load_wine(return_X_y=True)
# create an array of True for 2 and False otherwise
Expand All @@ -21,7 +19,7 @@ def test_dataset() -> Union[np.array, np.array]:
return X_test, y_test

@pytest.fixture
def model() -> sklearn.ensemble._forest.RandomForestClassifier:
def model() -> RandomForestClassifier:
REPO_ID = "electricweegie/mlewp-sklearn-wine"
FILENAME = "rfc.joblib"
model = joblib.load(hf_hub_download(REPO_ID, FILENAME))
Expand All @@ -38,4 +36,4 @@ def test_model_performance(model, test_dataset):
assert metrics['False']['f1-score'] > 0.95
assert metrics['False']['precision'] > 0.9
assert metrics['True']['f1-score'] > 0.8
assert metrics['True']['precision'] > 0.8
assert metrics['True']['precision'] > 0.8