ch04: Implement kqueue poll for macOS/BSD#42
Open
codyrioux wants to merge 1 commit intoPacktPublishing:mainfrom
Open
ch04: Implement kqueue poll for macOS/BSD#42codyrioux wants to merge 1 commit intoPacktPublishing:mainfrom
codyrioux wants to merge 1 commit intoPacktPublishing:mainfrom
Conversation
e685ad1 to
546c1f7
Compare
546c1f7 to
bb6215b
Compare
Collaborator
|
Thanks for the encouraging words! Doing what you did here is a great way to learn. I'm currently bogged down by work and a future second revision of this book, but I’ll get back to this later. Just wanted to let you know I appreciate the contribution and effort even though I wont be able to comment before later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a more or less 1:1 translation of the epoll code in ch04/a-epoll to kqueue eliminating the need for macOS and BSD users to run a virtual machine.
My objective in writing this was to motivate myself to understand the content of chapter 4 deeply enough to be capable of performing a translation. With that said I didn't know much about epoll before reading this chapter and knew nothing about kqueue until 4 hours ago, so I'm happy to take any feedback on the topic. However I did go through and attempt to comment and explain the differences between the kqueue code and the epoll code in the book such that a macOS or BSD user could follow the code and the chapter at the same time without a loss of fidelity.
Thank you for writing this book by the way! On occasion you run into a technical book that is just exceeds all your expectations and this is one of them. Well done.