Update react wrapper to PSPDFKit 5.0 #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also update package.json and package-lock.json to 1.21.2 or even 1.22.0, then tag a new release. |
irgendeinich
force-pushed
the
reinhard/update-pspdfkit
branch
from
b402b4d to
ad4dec5
Compare
tomassurin
approved these changes
Nov 13, 2018
|
|
||
| defaultConfig { | ||
| minSdkVersion 19 | ||
| targetSdkVersion 26 | ||
| versionCode 1 | ||
| versionName "1.0" | ||
| } | ||
|
|
||
| compileOptions { |
There was a problem hiding this comment.
Does this handle Java 8 source compatibility for customer's apps too? Shouldn't we mention this in the top level readme too?
anastasia-zaitsewa
approved these changes
Nov 14, 2018
irgendeinich
force-pushed
the
reinhard/update-pspdfkit
branch
from
0860434 to
00c8d60
Compare
Add mention to add java 8 to readme
irgendeinich
force-pushed
the
reinhard/update-pspdfkit
branch
from
00c8d60 to
f0c04df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #140
Updates the used PSPDFKit version to 5.0.
Resolves #139
Add the same waiting logic we already used for getting annotations to adding annotations.