Make listen interface configurable #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@boris-kloeckner Can you rebase your PR and sign our CLA? I'll then merge and release a new version |
boris-kloeckner
force-pushed
the
master
branch
from
68b9b07 to
a69728a
Compare
Contributor
Author
|
@MSch done |
|
@MSch Any plans on merging this? |
Collaborator
|
@boris-kloeckner merged! Thx a lot for your contributions! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a special use case which requires to use bypass in a docker compose so it should be able to receive requests coming from other containers.
This PR makes listen_ip configurable and keeps loopback as a default interface.
Solving #11