Fix incorrect GenServer.stop usage in Instance.dispatch_awaiting_callers#146
Open
IceDragon200 wants to merge 1 commit intoPSPDFKit-labs:masterfrom
Open
Fix incorrect GenServer.stop usage in Instance.dispatch_awaiting_callers#146IceDragon200 wants to merge 1 commit intoPSPDFKit-labs:masterfrom
IceDragon200 wants to merge 1 commit intoPSPDFKit-labs:masterfrom
Conversation
Based slightly off c-brenn's work, but with a more concise function for clarity
|
For what is worth, changes in this PR fixes the flakiness for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based slightly off c-brenn's work, but with a more concise function for reading clarity
Note
retained_plugs_countwas inefficient as it's usage was only to check for the presence of retained_plugs, rather than its actual count, it's quicker to just scan through the items and exit on the first entry.