Open
Conversation
bszaf
suggested changes
Jun 1, 2023
Contributor
bszaf
left a comment
bszaf
left a comment
There was a problem hiding this comment.
Please follow up with described changes.
bszaf
reviewed
Jun 12, 2023
| port = Bypass.Instance.call(pid, :port) | ||
| debug_log("Did open connection #{inspect(pid)} on port #{inspect(port)}") | ||
| bypass = %Bypass{pid: pid, port: port} | ||
| bypass = %Bypass{pid: pid, port: port, endpoint_url: "http://localhost:#{port}/"} |
Contributor
There was a problem hiding this comment.
localhost is usually resolves to loopback interface address - 127.0.0.1, however it is possible to bind to different interface. Therefore, the URL might not work.
It's safer to use use :inet.sockname/1 https://www.erlang.org/doc/man/inet.html#sockname-1 to retrieve listening address and then derive an interface address from :inet.getifaddrs/0 https://www.erlang.org/doc/man/inet.html#getifaddrs-0
There was a problem hiding this comment.
I see some overlap with a PR I just created. For the ip address I made this PR: #137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sometime can be a little annoying to add the
endpoint_urlto every test file or add it to the test case.As the endpoint url is something that in the majority of times the test needs to interact to be able to use bypass, seems to make sense that it could be grabbed easily. The port seems to be something more internal that not all tests would need to know and use.
Proposed Solution
Add
endpoint_urlfield to bypass struct. Existing code would work normally with existingportattribute.