Multiple expect_once

[ream88]

@ream88 any possibility of making it so that within one test I can stack two expect_once's so that the first call to the given route gets my first expect_once and the second call gets the second expect_once?
Currently the second expect_once would just redefine the first expect_once and I would get an error because the route is called twice.

Originally posted by @agramichael in #88 (comment)

[ream88]

Any help/PR would be very appreciated @agramichael @mrdougwright 😊

[mrdougwright]

Hmm, looked at the code a bit. Does it make sense to rework expect_once? Or is it better to have a new function, like expect_this? It looks rather tricky to change expect_once, since Bypass simply counts requests, and fails when there are too many.

[thiamsantos]

I was taking a look into this feature. I think we could change the data structure
of the expectations, to be a list of the expectations for the route.

When we have multiple expect_once we just append the new expectations, and after the call, we remove the called callback.
With that the main differences is that we wouldn't be able to count requests for request_once, as the callback would be removed from the list to be able to call the next one.
Also we wouldn't be able to redefine expect_onces as introduced by #80.

expect_once example:

Bypass.expect_once(bypass, "GET", "/foo", fun1)
Bypass.expect_once(bypass, "GET", "/foo", fun2)

Structure:

%{
  {"GET", "/foo"} => [
    %{
      expected: :once,
      fun: fun1,
      #...
    },
    %{
      expected: :once,
      fun: fun2,
      #...
    }
  ]
}

However for expect and stub the ideia is to remain the same,
each call to expect or stub will replace completely the list of expectations, and we only will have the last one.

expect example:

Bypass.expect_once(bypass, "GET", "/foo", fun1)
Bypass.expect(bypass, "GET", "/foo", fun2)

structure:

%{
  {"GET", "/foo"} => [
    %{
      expected: :once_or_more,
      fun: fun2,
      #...
    }
  ]
}

stub example:

Bypass.expect_once(bypass, "GET", "/foo", fun1)
Bypass.stub(bypass, "GET", "/foo", fun2)

Structure:

%{
  {"GET", "/foo"} => [
    %{
      expected: :none_or_more,
      fun: fun2,
      #...
    }
  ]
}

WDYT @ream88?

[cristopher-rodrigues]

any news here?