🪲 [Fix]: Skip revoke token if token is expired #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…token expiration before revoking access token
…` to check for token type and expiration before revoking access
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Disconnect-GitHubAccount function where token revocation was attempted even when the token was expired, causing failures. The fix adds a check to skip revocation for expired tokens and improves code readability through refactoring.
- Added expiration check to prevent revoking expired tokens
- Refactored compound conditional into separate variables for better maintainability
- Added debug statements to improve troubleshooting capabilities
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Module GitHub - 0.36.2 published to the PowerShell Gallery. |
|
GitHub release for GitHub v0.36.2 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the conditional logic in the
Disconnect-GitHubAccountfunction to improve readability and debugging and that actually skips the revocation of the token if it is expired.Refactoring and debugging improvements:
Revoke-GitHubAppInstallationAccessToken. The issue here was that the function would fail if it was expired.$isNotGitHubToken,$isIATAuthType, and$isNotExpiredfor clarity and maintainability.Write-Debugstatements for each condition to facilitate easier troubleshooting and understanding of the script's flow.Type of change
Checklist