Skip to content

🩹 [Patch]: Update environment variable prefixes for GitHub script inputs #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Feb 27, 2025

Description

This pull request focuses on updating environment variable names across multiple scripts to ensure consistency and clarity. The changes involve renaming variables from GITHUB_ACTION_INPUT_* to PSMODULE_GITHUB_SCRIPT_INPUT_*. This is to reduce the change of clobbering the envvars for the GitHub-Script action. Aligns with a undocumented decision of having all inputs of actions and workflows as <OWNER>_<REPO_NAME>_INPUT_*.

As this is internals of the action, this is deemed a patch update as nothing should rely on these variables apart from the scripts in the action.

  • Updated environment variable names in action.yml to use the PSMODULE_GITHUB_SCRIPT_INPUT_* prefix.
  • Modified scripts/info.ps1 to reflect the new environment variable names for ShowInfo, Token, and Debug settings. [1] [2] [3]
  • Adjusted scripts/init.ps1 to use the updated environment variable names for ShowInit, Version, Prerelease, Token, ClientID, and PrivateKey. [1] [2] [3]
  • Changed scripts/outputs.ps1 to use the new environment variable name for ShowOutput.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug self-assigned this Feb 27, 2025
@MariusStorhaug MariusStorhaug merged commit fe43ffe into main Feb 27, 2025
10 checks passed
@MariusStorhaug MariusStorhaug deleted the envvar branch February 27, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🩹 [Patch]: Rename the env vars for the action
1 participant