Skip to content

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jan 31, 2025

Description

This pull request includes updates to the Build-PSModuleManifest function in the scripts/helpers/Build/Build-PSModuleManifest.ps1 file. The changes aim to improve the handling of manifest properties by preserving existing values when they are present.

Key changes include:

  • Handling of RequiredAssemblies:

    • Added logic to preserve existing RequiredAssemblies values if they are present, otherwise populate with new values or set to an empty array if none are found. Now also includes *.dll files under the modules folder of the built module (non recursive).
  • Handling of NestedModules:

    • Added logic to preserve existing NestedModules values if they are present, otherwise populate with new values or set to an empty array if none are found. Now also includes *.dll files under the modules folder of the built module. Will only look on one level down, not recursively within each subfolder.
  • Handling of ScriptsToProcess:

    • Added logic to preserve existing ScriptsToProcess values if they are present, otherwise populate with new values or set to an empty array if none are found.

Type of change

  • 📖 [Docs]
  • 🪲 [Fix]
  • 🩹 [Patch]
  • ⚠️ [Security fix]
  • 🚀 [Feature]
  • 🌟 [Breaking change]

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner January 31, 2025 13:01
@MariusStorhaug MariusStorhaug self-assigned this Jan 31, 2025
@MariusStorhaug MariusStorhaug changed the title 🩹 [Patch]: Allow more overrides from manifest.psd1 🩹 [Patch]: Allow more overrides from manifest.psd1 + smarter defaults Feb 1, 2025
@MariusStorhaug MariusStorhaug merged commit f8e3b59 into main Feb 1, 2025
8 checks passed
@MariusStorhaug MariusStorhaug deleted the overrides branch February 1, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant