Set environment python to 3.6 by default #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asmockler Thanks for the PR. I'm fine with a complete switch to 3.6. The only issue is that I do not know when PolicyBrain will switch over to 3.6. @hdoupe Should we worry about the conflict? It doesn't seem like we are going to get OG-USA on TaxBrain anytime soon, so perhaps I shouldn't worry at all. |
|
No need to worry about the conflict. By the time OG-USA is up on PolicyBrain, PolicyBrain will be on 3.6. Thanks for checking. |
keiirizawa
pushed a commit
to keiirizawa/OG-USA
that referenced
this pull request
Mar 20, 2019
@asmockler . Hello from the rooftop of the Oberoi hotel in New Delhi. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on @jdebacker 's PR to make OG-USA compatible with 3.6 in #367 .
This PR makes python 3.6 the default for
ospcdyn. It also resolves warnings thrown by TaxCalculator when running the model.Note: I had to run
conda env update --pruneto get around some version conflicts from packages built for 2.7.cc: @rickecon