-
Notifications
You must be signed in to change notification settings - Fork 1
feat: show detail score #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements a detailed score-viewing feature by making list titles optional, adding a score modal and associated data fetching, and integrating the modal into the member information UI.
- Made
Listcomponentβstitleprop optional and updated rendering behavior. - Created
ScoreModalcomponent,useGetScorehook, and API call to fetch scores. - Integrated modal open/close logic into
InformationUI and wired up modal display.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/list.tsx | Made title optional and defaulted missing title |
| apps/admin/src/widgets/member/ui/information.tsx | Added modal state, handlers, and modal integration |
| apps/admin/src/entities/member/ui/scoreModal.tsx | Implemented score modal with data fetching |
| apps/admin/src/entities/member/model/useGetScore.ts | Added React Query hook to fetch scores |
| apps/admin/src/entities/member/model/score.ts | Defined score-related interfaces |
| apps/admin/src/entities/member/api/getScore.ts | Implemented API call with error handling |
Comments suppressed due to low confidence (2)
apps/admin/src/entities/member/ui/scoreModal.tsx:1
- No tests cover the
ScoreModalcomponent; consider adding unit or integration tests to validate modal rendering and data fetching behaviors.
"use client";
apps/admin/src/widgets/member/ui/information.tsx:57
- [nitpick] Slicing the ID starting at index 1 removes the first character of the username; verify this is intentional or adjust the slice range to include the full identifier.
id={student?.email?.split("@")[0]?.slice(1) as string}
|
β CI success |
|
β CI success |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
β CI success |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
β CI success |
πμμ λ΄μ©