Skip to content

Conversation

@bae080311
Copy link
Member

πŸ“μž‘μ—… λ‚΄μš©

상세 점수보기 κΈ°λŠ₯을 κ΅¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€

@bae080311 bae080311 self-assigned this Jul 6, 2025
@bae080311 bae080311 added the 🌟 Admin Admin νŽ˜μ΄μ§€μ™€ κ΄€λ ¨λœ 이슈λ₯Ό μž‘μ„±ν•΄μ£Όμ„Έμš”! label Jul 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Implements a detailed score-viewing feature by making list titles optional, adding a score modal and associated data fetching, and integrating the modal into the member information UI.

  • Made List component’s title prop optional and updated rendering behavior.
  • Created ScoreModal component, useGetScore hook, and API call to fetch scores.
  • Integrated modal open/close logic into Information UI and wired up modal display.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/shared/src/list.tsx Made title optional and defaulted missing title
apps/admin/src/widgets/member/ui/information.tsx Added modal state, handlers, and modal integration
apps/admin/src/entities/member/ui/scoreModal.tsx Implemented score modal with data fetching
apps/admin/src/entities/member/model/useGetScore.ts Added React Query hook to fetch scores
apps/admin/src/entities/member/model/score.ts Defined score-related interfaces
apps/admin/src/entities/member/api/getScore.ts Implemented API call with error handling
Comments suppressed due to low confidence (2)

apps/admin/src/entities/member/ui/scoreModal.tsx:1

  • No tests cover the ScoreModal component; consider adding unit or integration tests to validate modal rendering and data fetching behaviors.
"use client";

apps/admin/src/widgets/member/ui/information.tsx:57

  • [nitpick] Slicing the ID starting at index 1 removes the first character of the username; verify this is intentional or adjust the slice range to include the full identifier.
        id={student?.email?.split("@")[0]?.slice(1) as string}

@github-actions
Copy link

github-actions bot commented Jul 6, 2025

βœ… CI success

@bae080311 bae080311 changed the title Feat/show score feat: show detail score Jul 6, 2025
@github-actions
Copy link

github-actions bot commented Jul 6, 2025

βœ… CI success

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

βœ… CI success

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

βœ… CI success

@bae080311 bae080311 merged commit 001a137 into develop Jul 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 Admin Admin νŽ˜μ΄μ§€μ™€ κ΄€λ ¨λœ 이슈λ₯Ό μž‘μ„±ν•΄μ£Όμ„Έμš”!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants