Skip to content

fix(explore): import describeFilters where the page uses it (refs #801) - #821

Merged
PRODHOSH merged 1 commit into
PRODHOSH:mainfrom
SakethSumanBathini:fix/801-import-describe-filters
Aug 6, 2026
Merged

fix(explore): import describeFilters where the page uses it (refs #801)#821
PRODHOSH merged 1 commit into
PRODHOSH:mainfrom
SakethSumanBathini:fix/801-import-describe-filters

Conversation

@SakethSumanBathini

@SakethSumanBathini SakethSumanBathini commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Refs #801

src/app/explore/page.tsx calls describeFilters(activeFilters) at lines 421 and 447 but never imports it, so tsc reports:

src/app/explore/page.tsx(421,28): error TS2304: Cannot find name 'describeFilters'.
src/app/explore/page.tsx(447,46): error TS2304: Cannot find name 'describeFilters'.

The function is exported from @/lib/explore-filters, alongside buildExploreQuery and hasActiveFilters which this file already imports. One line added to the existing import block.

Scope

This is 2 of the 45 errors in #801, not a fix for that issue — hence refs rather than closes. I've posted a triage of the remainder there.

Worth flagging two of them, since both look like one-line fixes and aren't:

  • story/route.ts imports fetchProfileSnapshot; the compiler suggests getProfileSnapshot. Applying that rename takes the file from 1 error to 5 — getProfileSnapshot returns SnapshotRow, which has none of username, stats, repos or score that the caller reads. The two were written against different shapes.
  • view/route.ts calls checkRateLimit(key, { maxRequests: 10, windowMs: 60000 }). No such signature exists in @/lib/rate-limit — the real exports take a NextRequest and a namespace. That code was written against an API that either never landed or has since been replaced.

Both need whoever owns those features rather than a guess from outside.

Committed with --no-verify, since the pre-commit tsc --noEmit still fails on the other 43.

Summary by CodeRabbit

  • Enhancements
    • Improved Explore page descriptions for active filters and empty states.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Welcome to OSSfolio, @SakethSumanBathini! 🎉

Thank you for opening this pull request and contributing to the open-source community! 🚀

To ensure a smooth review process, please make sure you have:

  • Checked that your changes work locally and compile cleanly.
  • Followed the guidelines outlined in CONTRIBUTING.md.
  • Linked your PR to an open issue (e.g. Closes #ISSUE_NUMBER).

We will review your PR as soon as possible. Happy coding! 💻✨

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action Required: Please update your PR description to link the issue you are solving (e.g., write Closes #issue-number or Fixes #issue-number). This is required to pass automated validation status checks.

@github-actions github-actions Bot added the frontend Related to UI / Next.js label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5b1f811a-3b06-4f01-aa8a-187bf6e6dbf8

📥 Commits

Reviewing files that changed from the base of the PR and between 87724b8 and 132d16a.

📒 Files selected for processing (1)
  • src/app/explore/page.tsx

📝 Walkthrough

Walkthrough

The Explore page now imports describeFilters from @/lib/explore-filters for active-filter and empty-state descriptions.

Changes

Explore filter descriptions

Layer / File(s) Summary
Filter description wiring
src/app/explore/page.tsx
The Explore page imports describeFilters from @/lib/explore-filters.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: prodhosh, aditya8369

Poem

A rabbit brings a helper near,
To make filter words more clear.
Explore now knows what choices say,
In active states and empty display.
Hop, hop—the import leads the way!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the missing describeFilters import in the Explore page and matches the pull request objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PRODHOSH PRODHOSH added ELUSOC ELUSOC project submission completed NEWBIE Beginner — 10 pts beginner Good for newcomers labels Aug 6, 2026
@PRODHOSH
PRODHOSH merged commit 65abbf4 into PRODHOSH:main Aug 6, 2026
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginner Good for newcomers completed ELUSOC ELUSOC project submission frontend Related to UI / Next.js NEWBIE Beginner — 10 pts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants