added GET request for rating of projects #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh1nkey
commented
Feb 7, 2024
rate_projects/views.py
Outdated
| program_id = self.kwargs.get('program_id') | ||
|
|
||
|
|
||
| criterias = Criteria.objects.prefetch_related('partner_program').filter(partner_program_id=program_id) |
Member
Author
There was a problem hiding this comment.
вот тут вопрос. у меня несколько запросов к разным таблицам. надо ли мне сувать их в менеджеры данных таблиц? не факт, что они будут переиспользоваться
sh1nkey
commented
Feb 7, 2024
| criteria_serializer = CriteriaSerializer(data=criterias, many=True) | ||
| scores_serializer = ProjectScoreSerializer(data=[scores], many=True)# idk why it needs [], but don't fix what ain't broken | ||
|
|
||
| criteria_serializer.is_valid() |
Member
Author
There was a problem hiding this comment.
и тот же самый вопрос с сериалайзерами. я их так сделал, потому что не хочу переусложнять один единственный сериалайзер. так проще и понятнее. но нормально ли я сделал, что прям несколько отдельных вызываю по ходу кода? куда их можно вынести?
sh1nkey
commented
Feb 7, 2024
rate_projects/views.py
Outdated
|
|
||
|
|
||
| criterias = Criteria.objects.prefetch_related('partner_program').filter(partner_program_id=program_id) | ||
| scores = ( |
Member
Author
There was a problem hiding this comment.
если что, такие странные запросы обусловлены тем, что я использовал Django Silk (утилиту для отслеживания SQL запросов), и пытался ей угодить
sh1nkey
force-pushed
the
flexivanov237-pro-143
branch
from
9609b33 to
cbd1567
Compare
yakser
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
в комментариях укажу, где вопрос