Add a link to remove an author

Refs #388
PREreview · Oct 20, 2022 · 23e1f57 · 23e1f57
1 parent 9237939
commit 23e1f57
Show file tree

Hide file tree

Showing 27 changed files with 78 additions and 51 deletions.
diff --git a/assets/style.css b/assets/style.css
@@ -828,8 +828,21 @@ html-editor {
   padding-inline-start: 0;
 
   & > * {
+    display: flex;
+    flex-wrap: wrap;
+    justify-content: flex-end;
+    align-items: baseline;
+    column-gap: var(--space-s-m);
     border-block-end: var(--width-divider-narrow) solid var(--color-divider);
     padding-block: var(--space-3xs-2xs);
+
+    & > :not(a) {
+      flex-grow: 1;
+    }
+
+    @media (min-width: 40em) {
+      flex-wrap: nowrap;
+    }
   }
 
   & + * {

diff --git a/integration/posting-a-prereview.spec.ts b/integration/posting-a-prereview.spec.ts
@@ -459,7 +459,7 @@ test.extend(canAddAuthors)('can add other authors to the PREreview', async ({ fe
   await expect(page.locator('h1')).toHaveText('You have added 3 other authors')
   await expect(page).toHaveScreenshot()
 
-  await page.goto('/preprints/doi-10.1101-2022.01.13.476201/write-a-prereview/remove-author/1')
+  await page.click('role=link[name="Remove Otto Lidenbrock"]')
 
   await expect(page.locator('h1')).toHaveText('Are you sure you want to remove Otto Lidenbrock?')
   await expect(page).toHaveScreenshot()
@@ -1411,7 +1411,7 @@ test.extend(canAddAuthors)(
     await page.click('text="Save and continue"')
     await page.fill('role=textbox[name="Name"]', 'Jean-Baptiste Botul')
     await page.click('text="Save and continue"')
-    await page.goto('/preprints/doi-10.1101-2022.01.13.476201/write-a-prereview/remove-author/0')
+    await page.click('role=link[name="Remove Jean-Baptiste Botul"]')
 
     await page.click('text="Save and continue"')
 

diff --git a/....ts-snapshots/can-add-other-authors-to-the-PREreview-2-Desktop-Chrome-linux.png b/....ts-snapshots/can-add-other-authors-to-the-PREreview-2-Desktop-Chrome-linux.png
diff --git a/...an-add-other-authors-to-the-PREreview-2-Desktop-Chrome-no-JavaScript--linux.png b/...an-add-other-authors-to-the-PREreview-2-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...ts-snapshots/can-add-other-authors-to-the-PREreview-2-Desktop-Firefox-linux.png b/...ts-snapshots/can-add-other-authors-to-the-PREreview-2-Desktop-Firefox-linux.png
diff --git a/...n-add-other-authors-to-the-PREreview-2-Desktop-Firefox-no-JavaScript--linux.png b/...n-add-other-authors-to-the-PREreview-2-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-2-iPhone-11-linux.png b/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-2-iPhone-11-linux.png
diff --git a/...ots/can-add-other-authors-to-the-PREreview-2-iPhone-11-no-JavaScript--linux.png b/...ots/can-add-other-authors-to-the-PREreview-2-iPhone-11-no-JavaScript--linux.png
diff --git a/....ts-snapshots/can-add-other-authors-to-the-PREreview-3-Desktop-Chrome-linux.png b/....ts-snapshots/can-add-other-authors-to-the-PREreview-3-Desktop-Chrome-linux.png
diff --git a/...an-add-other-authors-to-the-PREreview-3-Desktop-Chrome-no-JavaScript--linux.png b/...an-add-other-authors-to-the-PREreview-3-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...ts-snapshots/can-add-other-authors-to-the-PREreview-3-Desktop-Firefox-linux.png b/...ts-snapshots/can-add-other-authors-to-the-PREreview-3-Desktop-Firefox-linux.png
diff --git a/...n-add-other-authors-to-the-PREreview-3-Desktop-Firefox-no-JavaScript--linux.png b/...n-add-other-authors-to-the-PREreview-3-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-3-iPhone-11-linux.png b/....spec.ts-snapshots/can-add-other-authors-to-the-PREreview-3-iPhone-11-linux.png
diff --git a/...ots/can-add-other-authors-to-the-PREreview-3-iPhone-11-no-JavaScript--linux.png b/...ots/can-add-other-authors-to-the-PREreview-3-iPhone-11-no-JavaScript--linux.png
diff --git a/...pshots/have-to-say-if-you-need-to-add-another-author-1-Desktop-Chrome-linux.png b/...pshots/have-to-say-if-you-need-to-add-another-author-1-Desktop-Chrome-linux.png
diff --git a/...say-if-you-need-to-add-another-author-1-Desktop-Chrome-no-JavaScript--linux.png b/...say-if-you-need-to-add-another-author-1-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...shots/have-to-say-if-you-need-to-add-another-author-1-Desktop-Firefox-linux.png b/...shots/have-to-say-if-you-need-to-add-another-author-1-Desktop-Firefox-linux.png
diff --git a/...ay-if-you-need-to-add-another-author-1-Desktop-Firefox-no-JavaScript--linux.png b/...ay-if-you-need-to-add-another-author-1-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/...s-snapshots/have-to-say-if-you-need-to-add-another-author-1-iPhone-11-linux.png b/...s-snapshots/have-to-say-if-you-need-to-add-another-author-1-iPhone-11-linux.png
diff --git a/...e-to-say-if-you-need-to-add-another-author-1-iPhone-11-no-JavaScript--linux.png b/...e-to-say-if-you-need-to-add-another-author-1-iPhone-11-no-JavaScript--linux.png
diff --git a/...pshots/have-to-say-if-you-need-to-add-another-author-2-Desktop-Chrome-linux.png b/...pshots/have-to-say-if-you-need-to-add-another-author-2-Desktop-Chrome-linux.png
diff --git a/...say-if-you-need-to-add-another-author-2-Desktop-Chrome-no-JavaScript--linux.png b/...say-if-you-need-to-add-another-author-2-Desktop-Chrome-no-JavaScript--linux.png
diff --git a/...shots/have-to-say-if-you-need-to-add-another-author-2-Desktop-Firefox-linux.png b/...shots/have-to-say-if-you-need-to-add-another-author-2-Desktop-Firefox-linux.png
diff --git a/...ay-if-you-need-to-add-another-author-2-Desktop-Firefox-no-JavaScript--linux.png b/...ay-if-you-need-to-add-another-author-2-Desktop-Firefox-no-JavaScript--linux.png
diff --git a/...s-snapshots/have-to-say-if-you-need-to-add-another-author-2-iPhone-11-linux.png b/...s-snapshots/have-to-say-if-you-need-to-add-another-author-2-iPhone-11-linux.png
diff --git a/...e-to-say-if-you-need-to-add-another-author-2-iPhone-11-no-JavaScript--linux.png b/...e-to-say-if-you-need-to-add-another-author-2-iPhone-11-no-JavaScript--linux.png
diff --git a/src/write-review/write-review-add-authors.ts b/src/write-review/write-review-add-authors.ts
@@ -17,6 +17,7 @@ import {
   writeReviewAddAuthorsMatch,
   writeReviewAuthorsMatch,
   writeReviewMatch,
+  writeReviewRemoveAuthorMatch,
 } from '../routes'
 import { NonEmptyString } from '../string'
 import { User, getUserFromSession } from '../user'
@@ -152,7 +153,20 @@ function addAuthorsForm(preprint: Preprint, authors: ReadonlyArray<{ name: NonEm
           <h1>You have added ${authors.length} other author${authors.length !== 1 ? 's' : ''}</h1>
 
           <ol class="summary-list">
-            ${authors.map(({ name }) => html` <li>${name}</li>`)}
+            ${authors.map(
+              ({ name }, index) => html`
+                <li>
+                  <span>${name}</span>
+                  <a
+                    href="${format(writeReviewRemoveAuthorMatch.formatter, {
+                      doi: preprint.doi,
+                      index,
+                    })}"
+                    >Remove<span class="visually-hidden"> ${name}</span></a
+                  >
+                </li>
+              `,
+            )}
           </ol>
 
           <div ${rawHtml(E.isLeft(form.anotherAuthor) ? 'class="error"' : '')}>