Skip to content

TOD literlas can now be parsed with 2 and 3 sections (#355) #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2021
Merged

TOD literlas can now be parsed with 2 and 3 sections (#355) #360

merged 3 commits into from
Nov 5, 2021

Conversation

99NIMI
Copy link
Member

@99NIMI 99NIMI commented Nov 3, 2021

No description provided.

@99NIMI 99NIMI requested review from ghaith and riederm November 3, 2021 09:28
@99NIMI 99NIMI linked an issue Nov 3, 2021 that may be closed by this pull request
TOD-Literal can only be parsed if it has 3 sections #355
Closed
riederm
riederm requested changes Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@riederm riederm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good,
can add the same treatment for DATE_AND_TIME?

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #360 (c7bf43b) into master (84ea37b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   95.76%   95.77%           
=======================================
  Files          51       51           
  Lines       14606    14611    +5     
=======================================
+ Hits        13988    13993    +5     
  Misses        618      618
Impacted Files Coverage Δ
src/parser/expressions_parser.rs 94.25% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ea37b...c7bf43b. Read the comment docs.

@99NIMI 99NIMI requested a review from riederm November 4, 2021 07:50
@99NIMI 99NIMI merged commit 4dd88ca into master Nov 5, 2021
@99NIMI 99NIMI deleted the issue-355-TOD-Literal_can_only_be_parsed_if_it_has_3_sections branch November 5, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riederm riederm riederm approved these changes

@ghaith ghaith Awaiting requested review from ghaith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TOD-Literal can only be parsed if it has 3 sections
3 participants
@99NIMI @codecov-commenter @riederm