Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce TO_<DATE,TIME> functions #1356

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Introduce TO_<DATE,TIME> functions #1356

wants to merge 2 commits into from

Conversation

volsa
Copy link
Member

@volsa volsa commented Nov 12, 2024

This commit introduces the TO_TOD and TO_LTOD functions, all making use of already existing X_TO_Y functions.

@volsa
feat: Introduce TO_<DATE,TIME> functions
bc01391 
This commit introduces the `TO_TOD` and `TO_LTOD` functions, all making use of already existing `X_TO_Y` functions.
@volsa volsa marked this pull request as ready for review November 14, 2024 12:02
@volsa volsa requested a review from mhasel November 14, 2024 12:03
mhasel
mhasel reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@mhasel mhasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might have missed TO_LDATE here.

Are conversions between date-time types also required/planned? I.e. FUNCTION TO_DATE__DATE_AND_TIME : DATE etc, see date_time_conversion_functions in the stdlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhasel mhasel mhasel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volsa @mhasel