feat: improved navigation of Course unit #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Temporary PR, after review the code will be moved to frontend-build |
PKulkoRaccoonGang
changed the title
ihor-romaniuk
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
CourseandSequencecomponents and their associated tests. The most important changes involve skipping certain tests, removing session storage logic, and updating test assertions.YouTrack
Test Updates:
src/course-home/data/pact-tests/lmsPact.test.jsx: Skipped tests for fetching tab and date blocks data for acourse_id. [1] [2]src/courseware/course/Course.test.jsx: Skipped tests related to notification triggers and tray toggling. [1] [2] [3]src/courseware/course/sequence/Sequence.test.jsx: Updated button role assertions and addedwithinfor better element scoping. [1] [2] [3]Code Simplification:
src/courseware/course/Course.jsx: Removed session storage logic for notification tray status.src/courseware/course/sequence/Sequence.jsx: Removed aconsole.logstatement.Minor Adjustments:
src/courseware/course/sequence/Sequence.test.jsx: Added missing import forwithinfrom@testing-library/react.src/courseware/course/sequence/Sequence.test.jsx: Corrected the number of timesunitNavigationHandleris called in assertions.