Render analytic demo dungeon with FOV overlays by PJensen · Pull Request #4 · PJensen/JSHack

PJensen · 2025-11-06T19:32:25Z

Summary

expose dungeon geometry metadata and actor sizing in the world view for rendering helpers
draw analytic room walls, floor dots, bounding circles, and reach overlays in the MVP demo scene
approximate a ray-marched FOV cone using the geometry snapshot while storing kernel options for rebuilds

Testing

npm test (fails: Cannot find module '/workspace/JSHack/src/lib/ecs-js/index.js' imported from tests/blockMonsters.mjs)

https://chatgpt.com/codex/tasks/task_e_690ccbee2b4c8333b4d7b38afab2f2e1

Copilot

Pull Request Overview

This PR migrates the game from a grid-based discrete movement system to a continuous analytic movement system. The changes introduce a geometry kernel for collision detection and raycasting, replace integer grid coordinates with floating-point positions, and add new components for bounding circles, facing directions, and anatomical reach/stride properties.

Key Changes:

Introduced GeometryKernel for analytic collision detection and raycasting using signed distance fields
Converted Position from integer to floating-point coordinates
Added BoundingCircle, Facing, and extended Anatomy components for continuous movement
Refactored movementSystem to use capsule sweeps and continuous collision detection instead of grid-based blocking maps

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
src/rules/environment/GeometryKernel.js	New kernel implementing SDF-based collision detection and raycasting
src/rules/environment/primitives.js	Geometric utility functions for distance fields and bounding boxes
src/rules/environment/worldGeometry.js	Kernel lifecycle management attached to world instance
src/rules/environment/dungeonGenerator.js	Room generation using geometry kernel
src/rules/components/Position.js	Changed validation from integer to floating-point coordinates
src/rules/components/MoveIntent.js	Added continuous direction vectors and optional distance override
src/rules/components/BoundingCircle.js	New component for collision radius
src/rules/components/Facing.js	New component for entity facing direction
src/rules/components/Anatomy.js	Added strideDistance and reachDistance fields
src/rules/components/DungeonGeometry.js	New component storing serialized geometry primitives
src/rules/systems/movementSystem.js	Complete rewrite for analytic movement with capsule sweeps
src/rules/systems/combatSystem.js	Updated range checks to use continuous distances
src/rules/systems/aiChaseSystem.js	Changed from grid steps to continuous direction vectors
src/rules/systems/itemPickupSystem.js	Updated pickup range to use continuous distances
src/rules/utils/queries.js	Changed equality checks to floating-point epsilon comparisons
src/rules/archetypes/Player.js	Added BoundingCircle, Facing, and Anatomy components
src/rules/archetypes/Creatures.js	Added continuous movement components to creature archetypes
src/main/scene/demoScene.js	Updated scene generation to use geometry kernel
src/main.js	Added dungeon rendering and FOV cone visualization
src/display/input/InputManager.js	Enhanced pointer handling with world coordinate conversion
src/bridge/schema/worldView.js	Extended view schema with geometry and continuous movement data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-06T19:36:21Z

src/rules/systems/movementSystem.js

+      actorData.radius = actorRadius;
+      actorData.x = pos.x;
+      actorData.y = pos.y;
+      actorData.solid = true;


Redundant assignments detected. Lines 83-86 reassign properties that were just set in the default object (lines 76-79, 82). Either use the values directly from the existing object or only set them once in the default initializer.

Suggested change

actorData.radius = actorRadius;

actorData.x = pos.x;

actorData.y = pos.y;

actorData.solid = true;

Copilot · 2025-11-06T19:36:22Z

src/rules/environment/primitives.js

@@ -0,0 +1,163 @@
+const TAU = Math.PI * 2;


Missing JSDoc comment for the TAU constant. Consider documenting that TAU represents 2π (a full circle in radians) for developers unfamiliar with this mathematical convention.

Copilot · 2025-11-06T19:36:22Z

src/main.js

+const TAU = Math.PI * 2;
+const WALL_THICKNESS = 0.45;
+const FOV_RAY_COUNT = 96;
+const FOV_MIN_DISTANCE = 6;


Magic numbers lack documentation. These rendering configuration constants should have JSDoc comments explaining their purpose and how changing them affects rendering quality and performance.

Suggested change

const FOV_MIN_DISTANCE = 6;

const FOV_MIN_DISTANCE = 6;

/**

* Maximum distance (in tiles) for field-of-view (FOV) raycasting.

* Increasing this value allows entities to see farther, improving visual range,

* but may reduce performance due to more extensive calculations.

* Lowering it can improve performance at the cost of reduced visibility.

* Tune based on desired gameplay and performance characteristics.

*/

Copilot · 2025-11-06T19:36:22Z

src/rules/systems/movementSystem.js

+      for (const other of colliderMap.values()) {
+        if (other.id === actor) continue;
+        if (!other.solid) continue;
+        const minDist = actorRadius + other.radius;
+        if (minDist <= 0) continue;
+        const dist = Math.hypot(dest.x - other.x, dest.y - other.y);
+        if (dist < minDist - EPS) {
+          blockedBy = other;
+          break;
+        }
+      }


Potential performance issue: O(n²) collision detection where n is the number of entities. For every moving actor, this iterates through all colliders. Consider implementing spatial partitioning (e.g., grid-based bucketing or a spatial hash) to reduce collision checks, especially as entity count grows.

Copilot · 2025-11-06T19:36:23Z

src/rules/environment/GeometryKernel.js

+  #gradient(fn, x, y, h) {
+    const hh = Math.max(EPS, h ?? this.options.gradientStep);
+    const dx = fn(x + hh, y) - fn(x - hh, y);
+    const dy = fn(x, y + hh) - fn(x, y - hh);
+    const inv = 1 / (2 * hh);
+    const gx = dx * inv;
+    const gy = dy * inv;
+    const mag = Math.hypot(gx, gy);
+    if (mag === 0) return { x: 0, y: -1 };
+    return { x: gx / mag, y: gy / mag };
+  }


Missing JSDoc for private method. While private, this method implements central finite difference gradient estimation which is non-trivial. Add a comment explaining the numerical gradient computation approach for maintainability.

Copilot · 2025-11-06T19:36:23Z

src/display/input/InputManager.js

+    const dx = wx - origin.x;
+    const dy = wy - origin.y;
+    if (Math.abs(dx) < 1e-4 && Math.abs(dy) < 1e-4) return;


Inconsistent epsilon values used for floating-point comparisons. This uses 1e-4, while other files use 1e-6 (queries.js line 10), 1e-3 (combatSystem.js line 75), and EPS constants. Consider defining a shared constant for epsilon thresholds to ensure consistency across the codebase.

Copilot · 2025-11-06T19:36:23Z

src/rules/environment/GeometryKernel.js

+    const finalPoint = { x: origin.x + ux * Math.min(t, maxT), y: origin.y + uy * Math.min(t, maxT) };
+    return { hit: false, point: finalPoint, t: Math.min(t, maxT), steps };
+  }
+


Missing JSDoc for public API method. The sweepCapsule method is a critical public API for collision detection but lacks documentation explaining its parameters (start, end, radius, opts) and return value structure. Add comprehensive JSDoc to improve API usability.

Suggested change

/**

* Sweeps a capsule (line segment with radius) from `start` to `end` and checks for collision along the path.

*

* @param {{x: number, y: number}} start - The starting point of the capsule's center line.

* @param {{x: number, y: number}} end - The ending point of the capsule's center line.

* @param {number} radius - The radius of the capsule.

* @param {Object} [opts={}] - Optional parameters for sweep behavior.

* @param {number} [opts.maxSteps] - Maximum number of sweep steps (default: this.options.maxSweepSteps).

* @param {number} [opts.minStep] - Minimum step size (default: this.options.sweepMinStep).

* @param {number} [opts.epsilon] - Hit threshold (default: this.options.rayEpsHit).

* @returns {Object} Result of the sweep.

* @returns {boolean} result.hit - Whether a collision was detected.

* @returns {{x: number, y: number}} result.point - The point where collision occurred or where sweep ended.

* @returns {number} result.t - The normalized distance along the sweep (0=start, 1=end).

* @returns {number} result.steps - Number of steps performed during the sweep.

* @returns {{x: number, y: number}} result.normal - The collision normal at the hit point.

*/

Copilot · 2025-11-06T19:36:24Z

src/rules/environment/GeometryKernel.js

+    const epsStep = this.options.rayEpsStep;
+    let t = 0;
+    let steps = 0;
+    let lastPoint = { x: origin.x, y: origin.y };


The initial value of lastPoint is unused, since it is always overwritten.

Suggested change

let lastPoint = { x: origin.x, y: origin.y };

Copilot · 2025-11-06T19:36:24Z

src/rules/environment/GeometryKernel.js

+        return { hit: true, point: { x: px, y: py }, t, steps };
+      }
+      const delta = Math.max(dist, epsStep);
+      lastPoint = { x: px, y: py };


The value assigned to lastPoint here is unused.

Copilot · 2025-11-06T19:36:24Z

src/rules/environment/GeometryKernel.js

+        };
+      }
+      prevT = traveled;
+      prevClear = clearance;


The value assigned to prevClear here is unused.

Suggested change

prevClear = clearance;

Render analytic dungeon dungeon and FOV

d228c1a

Copilot AI review requested due to automatic review settings November 6, 2025 19:32

PJensen added the codex label Nov 6, 2025 — with ChatGPT Codex Connector

Copilot AI reviewed Nov 6, 2025

View reviewed changes

PJensen merged commit ba055a9 into master Nov 6, 2025
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render analytic demo dungeon with FOV overlays#4

Render analytic demo dungeon with FOV overlays#4
PJensen merged 1 commit intomasterfrom
codex/build-environment-for-dungeon-simulation-iwvzyn

PJensen commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-const FOV_MIN_DISTANCE = 6;
+const FOV_MIN_DISTANCE = 6;
+/**
+ * Maximum distance (in tiles) for field-of-view (FOV) raycasting.
+ * Increasing this value allows entities to see farther, improving visual range,
+ * but may reduce performance due to more extensive calculations.
+ * Lowering it can improve performance at the cost of reduced visibility.
+ * Tune based on desired gameplay and performance characteristics.
+ */

+  /**
+   * Sweeps a capsule (line segment with radius) from `start` to `end` and checks for collision along the path.
+   *
+   * @param {{x: number, y: number}} start - The starting point of the capsule's center line.
+   * @param {{x: number, y: number}} end - The ending point of the capsule's center line.
+   * @param {number} radius - The radius of the capsule.
+   * @param {Object} [opts={}] - Optional parameters for sweep behavior.
+   * @param {number} [opts.maxSteps] - Maximum number of sweep steps (default: this.options.maxSweepSteps).
+   * @param {number} [opts.minStep] - Minimum step size (default: this.options.sweepMinStep).
+   * @param {number} [opts.epsilon] - Hit threshold (default: this.options.rayEpsHit).
+   * @returns {Object} Result of the sweep.
+   * @returns {boolean} result.hit - Whether a collision was detected.
+   * @returns {{x: number, y: number}} result.point - The point where collision occurred or where sweep ended.
+   * @returns {number} result.t - The normalized distance along the sweep (0=start, 1=end).
+   * @returns {number} result.steps - Number of steps performed during the sweep.
+   * @returns {{x: number, y: number}} result.normal - The collision normal at the hit point.
+   */

Conversation

PJensen commented Nov 6, 2025

Summary

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants