Skip to content

Add demo entry door and shrink player collision radius#14

Merged
PJensen merged 1 commit intomasterfrom
codex/adjust-player-bounding-circle-for-passageway
Nov 9, 2025
Merged

Add demo entry door and shrink player collision radius#14
PJensen merged 1 commit intomasterfrom
codex/adjust-player-bounding-circle-for-passageway

Conversation

@PJensen
Copy link
Owner

@PJensen PJensen commented Nov 9, 2025

Summary

  • reduce the default player bounding circle radius so 1-tile corridors are traversable
  • add and reset a closed door at the demo scene hallway entrance for interaction testing

Testing

  • npm test (fails: Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/workspace/JSHack/src/lib/ecs-js/index.js')

Codex Task

Copilot AI review requested due to automatic review settings November 9, 2025 16:41
@PJensen PJensen merged commit 494d603 into master Nov 9, 2025
4 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the player's default bounding radius to enable navigation through single-tile corridors and adds a door to the demo scene for testing gameplay mechanics.

  • Reduced player's default bounding circle radius from 0.55 to 0.45
  • Added door placement functionality to the demo scene

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/rules/archetypes/Player.js Updated default BoundingCircle radius to 0.45 in both the archetype definition and fallback createPlayer function, with explanatory comment
src/main/scene/demoScene.js Added placeEntryDoor function with necessary imports to place a door in the demo room for testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants