Support for threshold signatures #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>>> from dash@cd67e12048284f051c7a3fe8decfa6f81faaa246
>>> based on dash@7ff741900d99774849259ecde2c4a1dfa128414f without support for Legacy scheme
>>> from dash@66e343a06c6aa9ba83a2d18651bff065af52fa27
>>> from dash@aa1a41b0b86b7d1304b18e67dc285afc723ef9bf
>>> from dash@662386a9910cc59a3f38f0872a8d7e21b8d79454 without test for legacy scheme
furszy
reviewed
Jul 8, 2021
| return ret; | ||
| } | ||
|
|
||
| PrivateKey operator*(const bn_t& a, const PrivateKey& k) { return a * k; } |
There was a problem hiding this comment.
how this makes any sense? it's an infinite recursion.
a * k will call internally a * k that will call internally a * k...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport relevant changes from Dash library, excluding the support for legacy scheme.