[Build] Update to latest leveldb #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: src/leveldb git-subtree-split: 64052c7
(cherry picked from commit ffee03c)
Also for libsecp256k1 now that it has been updated
|
Since this is a huge PR, would it be sufficient to run a Gitian build for all OSs to test it properly? |
Collaborator
Author
|
build and unit tests are always good, but this one also needs extensive runtime testing with new and existing chain/wallet data. |
Warrows
approved these changes
Aug 10, 2018
|
I'm starting to test this right now and will report back in a day or so... |
(to be continued...) |
Mrs-X
added a commit
that referenced
this pull request
Aug 18, 2018
85c2a28 travis: run subtree checks for leveldb (Fuzzbawls) 1d99c21 build: update build system for new leveldb (Fuzzbawls) 4f5b53d Squashed 'src/leveldb/' content from commit 64052c7 (Fuzzbawls) d3e48bd Remove leveldb path in prep for subtree init (Fuzzbawls) Tree-SHA512: de3d6fc36393866c8aefde550bb015e6de1c77684653d2e140ff90d638aa3d47c63b12f826fa474cc004f888d76c4108c4516f99cb6c77afb40336ea8f631cfa
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to a git subtree for leveldb (similar to univalue and secp256k1)
This also fixes #534