fix(rename): handle variables in dynamic property selectors - #174
Merged
Conversation
calebdw
force-pushed
the
calebdw/push-tmorwosozptt
branch
from
June 26, 2026 21:42
8ad94da to
2d89408
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
calebdw
force-pushed
the
calebdw/push-tmorwosozptt
branch
from
July 3, 2026 17:52
2d89408 to
85ddd6b
Compare
Dynamic property selectors like `$message->{$attribute}` were only
partially
walked. The scope collector skipped selector expressions when tracking
local
variable reads, which caused false `unused_variable` diagnostics for the
selector variable.
The symbol map extractor also ignored non-identifier property selectors,
so
find-references and rename missed variable occurrences inside dynamic
property
accesses. Renaming `$attribute` updated plain variable uses but not the
selector inside `$message->{$attribute}`.
Walk selector expressions during scope collection and emit variable
symbol
spans for dynamic property selectors in the symbol map. Add regression
tests
covering unused-variable diagnostics, references, and rename behavior
for this
pattern.
Signed-off-by: Anders Jenbo <anders@jenbo.dk>
AJenbo
force-pushed
the
calebdw/push-tmorwosozptt
branch
from
July 4, 2026 01:29
85ddd6b to
cb8f842
Compare
AJenbo
enabled auto-merge (rebase)
July 4, 2026 01:29
AJenbo
disabled auto-merge
July 4, 2026 01:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic property selectors like
$message->{$attribute}were only partially walked. The scope collector skipped selector expressions when tracking local variable reads, which caused falseunused_variablediagnostics for the selector variable.The symbol map extractor also ignored non-identifier property selectors, so find-references and rename missed variable occurrences inside dynamic property accesses. Renaming
$attributeupdated plain variable uses but not the selector inside$message->{$attribute}.Walk selector expressions during scope collection and emit variable symbol spans for dynamic property selectors in the symbol map. Add regression tests covering unused-variable diagnostics, references, and rename behavior for this pattern.