Skip to content

Conversation

@oleibman
Copy link
Collaborator

Fix #4638. Microsoft does not document BASE as being introduced in Excel 2010 or later, but apparently it was.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Fix PHPOffice#4638. Microsoft does not document BASE as being introduced in Excel 2010 or later, but apparently it was.
@oleibman oleibman enabled auto-merge September 12, 2025 03:27
@oleibman oleibman added this pull request to the merge queue Sep 12, 2025
Merged via the queue into PHPOffice:master with commit c07675a Sep 12, 2025
13 checks passed
@oleibman oleibman deleted the issue4638 branch September 12, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Formula with BASE function is corrupted on save, leading to #NAME? error in Excel

1 participant