Conditional Formatting in extLst #4633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4629. Excel Xml can specify Conditional Formatting in 2 ways - either using a
conditionalFormattingtag as a child ofworksheet, or in a slightly different manner as a child ofworksheet->extLst. Although these are both handled by PhpSpreadsheet, the former is lost if there exists a latter whose cell range (sqref) matches it. This PR merges the former with the latter in that circumstance, preserving both.The issue also notes that
fontandstopIfTrueare not handled correctly. Support for those was missing in theextlsthandling, and is now added with this PR.This is:
Checklist: