PHP 8.5: Prevent deprecation notices for imagedestroy

[TobiasBg]

imagedestroy is deprecated in PHP 8.5+, and hasn't been doing anything since PHP 8.0.

To prevent deprecation warnings it should therefore be called on older versions of PHP only.

See https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_no-op_functions_from_the_resource_to_object_conversion.

This is:

• a bugfix
• a new feature
• refactoring
• additional unit tests

Checklist:

• Changes are covered by unit tests
  • Changes are covered by existing unit tests
  • New unit tests have been added
• Code style is respected
• Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
• CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
• Documentation is updated as necessary

[oleibman]

Thank you for identifying this problem. We do not support any Php release below 8.1, so you can just delete the imagedestroy statement. This will satisfy both phpstan and (probably) coveralls. Please make that change and I will move this forward.

[TobiasBg]

Ah, yes, of course! Then the imagedestroy call can be removed entirely.

[oleibman]

Sorry, I wasn't sure if you were around today, so I made that change myself. I was really curious to see how Coveralls handled the change. It did well. I deleted 2 statements, which actually resulted in reduced coverage - previous was 74/102 = 72.5%, new is 72/100 = 72%. This will just happen sometimes, and Coverall reported success.

[oleibman]

Thank you for your contribution.

[TobiasBg]

No worries! I assume it's even faster for you to just make these small changes than working of PRs sometimes :-)

Good to hear that this is helpful!