Skip to content

Conversation

@oleibman
Copy link
Collaborator

Fix #1104, which went stale over 6 years ago, and is now reopened. This PR addresses the alignment of the table, not alignment of text. Support is added for the following:

  • Html. Full support.
  • Mpdf. Full support, except that, when mixed LTR and RTL worksheets are output, all tables will be on the left of the page (but will be properly aligned).
  • Tcpdf. Full support when all worksheets being output are RTL; no support when mixed LTR and RTL worksheets are output.
  • Dompdf. No support.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

oleibman added 3 commits July 14, 2025 00:22
Fix PHPOffice#1104, which went stale over 6 years ago, and is now reopened. This PR addresses the alignment of the table, not alignment of text. Support is added for the following:

- Html. Full support.
- Mpdf. Full support, except that, when mixed LTR and RTL worksheets are output, all tables will be on the left of the page (but will be properly aligned).
- Tcpdf. Full support when all worksheets being output are RTL; no support when mixed LTR and RTL worksheets are output.
- Dompdf. No support.
@oleibman oleibman enabled auto-merge July 18, 2025 04:45
@oleibman oleibman added this pull request to the merge queue Jul 18, 2025
Merged via the queue into PHPOffice:master with commit b442eef Jul 18, 2025
13 of 14 checks passed
@oleibman oleibman deleted the issue1104 branch July 18, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[a feature request] Can't set the pdf file direction to RTL

1 participant