Skip to content

Ods Reader No Datatype for Null Value #4436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2025
Merged

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Apr 4, 2025

Issue #4435 was initially described incorrectly. While investigating the original description, I came upon this problem. Ods Reader is trying to set some cells to null without supplying a valid DataType to setValueExplicit, causing that method to throw an exception. Reader is changed to no longer call that method when value is null and DataType is null-string.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Issue PHPOffice#4435 was initially described incorrectly. While investigating the original description, I came upon this problem. Ods Reader is trying to set some cells to null without supplying a valid DataType to setValueExplicit, causing that method to throw an exception. Reader is changed to no longer call that method when value is null and DataType is null-string.
@oleibman
Copy link
Collaborator Author

oleibman commented Apr 4, 2025

No idea why Scrutinizer error-ed. Don't really care.

@oleibman oleibman enabled auto-merge April 6, 2025 00:30
@oleibman oleibman added this pull request to the merge queue Apr 6, 2025
Merged via the queue into PHPOffice:master with commit 86cca12 Apr 6, 2025
13 of 14 checks passed
@oleibman oleibman deleted the issue4435 branch April 6, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant