Skip to content

Phpstan Level 9 - Part 1 of Many #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Mar 6, 2025

Dealing mostly with mixed variable type. In a great many cases, problems can be resolved replacing getValue with getValueString or getCalculatedValue with getCalculatedValueString.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • code quality

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

oleibman added 3 commits March 5, 2025 21:59
Dealing mostly with mixed variable type. In a great many cases, problems can be resolved replacing `getValue` with `getValueString` or `getCalculatedValue` with `getCalculatedValueString`.
@oleibman oleibman enabled auto-merge March 8, 2025 05:56
@oleibman oleibman disabled auto-merge March 8, 2025 05:58
@oleibman oleibman enabled auto-merge March 8, 2025 06:18
@oleibman oleibman added this pull request to the merge queue Mar 8, 2025
Merged via the queue into PHPOffice:master with commit 20aac08 Mar 8, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant