Resolve Conditional Formatting issues with Xls writer #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 12, 2022 20:54
…kground colour is still a problem, so that it's easy to verify that the rule is beng written correctly
… for conditional formatting rules in the Xls file save The code is ugly as sin; but it works... I'll do some refactoring and cleaning later (once I've had some sleep, because I'm stupidly still working on this at 3am) The main remaining issue is formulae that can't be parsed in BIFF8 files; e.g. formulae that use functions that aren't available. In this case, all CF in that worksheet is corrupted, and the file errors when opened, so it is a serious issue. The ISODD()/ISEVEN example in 07_Expression_Comparisons.php uses these, so I've temporarily commented out setting that CF range until I've solved that problem. There are other limitations listed in the BIFF documentation; but they're harder to detect. I've also left a couple of debug statements in the code to display these formula errors: I'll remove them once I've resolved the issue.
Member
Author
|
I guess I'll also need to create a series of unit tests for CF Writing both for Xlsx and Xls; create, save, reload and verify that they're as written. That's not going to be easy, as the Xls Reader doesn't read conditional formatting :-( |
added 3 commits
March 13, 2022 04:02
…tokens and size, to reduce duplicated code
…ich will avoid breaking the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
This PR resolves the problem with writing a CF Header for each CF range, no matter how many rules there are for that range, rather than writing a single header for all ranges.
It does not appear that this has ever worked correctly, and that only writing a single CF range was supported before, but recent changes to provide examples of multiple CF ranges in a single worksheet have highlighted the problem, while a modification to the Xls Writer to support multiple ranges actually broke the CF Writer so that Excel issues a warning when the file is opened.
Now the code can also handle:
None of these previously worked. All cell reference, string literal or formula expressions used as rule values were silently converted to integer 0
In the event of s formula expressions that Xls itself doesn't support (e.g. when they use an Excel function that isn't known to the BIFF format), the code defaults the condition to
ptgInt+0 (=0) to avoid breaking the structure of the file.