feature:low memory to export Excel #2524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 24, 2022 18:18
By adjusting and rewriting the order of save method, we use another way to "save" to reduce the memory use when we export a lot of data.
fix the style problems
fix the style problems
fix the style problems
fix the style problems
fix the style problems
|
@MarkBaker please help review this |
to fix some problems by phpstan
guanguoliang
commented
Feb 11, 2022
| // Get row dimension | ||
| $rowDimension = $pSheet->getRowDimension($currentRow); | ||
| // Write current row? | ||
| $writeCurrentRow = isset($cellsByRow[$stringCurrentRow]) || $rowDimension->getRowHeight() >= 0 || $rowDimension->getVisible() == false || $rowDimension->getCollapsed() == true || $rowDimension->getOutlineLevel() > 0 || $rowDimension->getXfIndex() !== null; |
There was a problem hiding this comment.
this check failure of phpstan is a bug , please view this: phpstan/phpstan#3170
to fix some problems by php-cs-fixer and Scrutinizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adjusting and rewriting the order of save method, we use another way to "save" to reduce the memory use when we export a lot of data.
This is:
Checklist:
Why this change is needed?