Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1114 issue #2308

Merged
merged 7 commits into from
Oct 3, 2021
Merged

fix #1114 issue #2308

merged 7 commits into from
Oct 3, 2021

Conversation

tezrik
Copy link
Contributor

@tezrik tezrik commented Sep 27, 2021

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Fixed #1114 issue

@oleibman
Copy link
Collaborator

Can you add a unit test which (a) fails without your change and (b) succeeds with your change?

@tezrik
Copy link
Contributor Author

tezrik commented Sep 29, 2021

I add test

@oleibman
Copy link
Collaborator

Thanks. I plan to merge this in a few days. In the meantime, can you please expand on this comment "this has to do with that index 4 is omitted in all BIFF versions for some strange reason ... check the OpenOffice documentation of the FONT record"? If there is something in the official documentation, I would just like to include it with this PR. You can just include it as a comment in the PR; not necessary to add it to the source code.

@tezrik
Copy link
Contributor Author

tezrik commented Sep 29, 2021

I remove comment about "index in all biff version". In documentation OpenOffice not explanations on issue #1114.

@oleibman oleibman merged commit fea0e34 into PHPOffice:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error when loading file
2 participants