Closed
Description
matchSmallestValue does not have any extra handling to make sure double and integer types are treated as matchable.
$typeMatch = gettype($lookupValue) === gettype($lookupArrayValue);
Both matchFirstvalue and matchLargestValue use:
$typeMatch = ((gettype($lookupValue) === gettype($lookupArrayValue)) || (is_numeric($lookupValue) && is_numeric($lookupArrayValue)));
This results in the matcher for matchSmallestValue skipping valid comparisons when one of the values is an integer and the other a double.
I had no problems just reusing the logic from the other matching functions.
Metadata
Metadata
Assignees
Labels
No labels