Renamed String to SharedString #628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…haredString, as String is a special class name as of PHP7
Member
|
Or use PHPOffice\Common ;) I just added the PR for it #658 |
Closed
|
Hello @RomanSyroeshko , any chance this will be accepted? We need to run one project on php7, and only this library is stopping us. Thank you! |
Contributor
|
PHP 7 is out and I think there should be a quick fix release, right? |
|
I do wait for this very much! |
|
The tests are failing because the test cases have not been renamed. I think all you need to do is:
|
|
We need this PR too. The last issue breaks our project on php7.. |
|
I guess this PR is superceded by #698 |
Member
|
Or #658 |
ghost
self-assigned this
|
Guys, thank you very much for voting. I'll try to handle that this weekend. |
Closed
|
Resolved in scope of #658. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed PhpOffice\PhpWord\Shared\String to PhpOffice\PhpWord\Shared\SharedString, as String is a special class name as of PHP7