Skip to content

Conversation

@dgudgeon
Copy link

@dgudgeon dgudgeon commented Apr 1, 2014

Include document headers and footers in template find & replace functionality.

@Progi1984 Progi1984 added the Pull label Apr 1, 2014
@Progi1984 Progi1984 added this to the 0.9.2 milestone Apr 1, 2014
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why three ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only information I could find on this suggested that three was the maximum number allowed. Is that incorrect?

I could change it to loop until headerN.xml doesn't exist perhaps?

@dgudgeon
Copy link
Author

dgudgeon commented Apr 1, 2014

Updated to look for header and footer files until one does not exist.

@ivanlanin
Copy link
Contributor

This pull will resolve issue #50

@ivanlanin ivanlanin self-assigned this Apr 2, 2014
@ivanlanin
Copy link
Contributor

I'll review and merge this today.

@Progi1984
Copy link
Member

Good job @dgudgeon :)

@dgudgeon
Copy link
Author

dgudgeon commented Apr 2, 2014

Great, thanks guys!

ivanlanin added a commit that referenced this pull request Apr 2, 2014
@ivanlanin ivanlanin merged commit 4f514d2 into PHPOffice:develop Apr 2, 2014
@ivanlanin
Copy link
Contributor

Merged. We thank you :)

@dgudgeon dgudgeon deleted the template-header-and-footer branch April 7, 2014 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants