Skip to content

Conversation

@Alexmg86
Copy link
Contributor

@Alexmg86 Alexmg86 commented Dec 6, 2018

Description

Add support for hidden text.
http://www.datypic.com/sc/ooxml/e-w_vanish-1.html

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@troosan
Copy link
Contributor

troosan commented Dec 6, 2018

@Alexmg86 Thanks for this, could you please update the documentation, and add a unit test to cover this new feature?

@Alexmg86
Copy link
Contributor Author

Alexmg86 commented Dec 8, 2018

@troosan Thanks, i was added description in docs. But i don't know how write unit test ((( sorry

@coveralls
Copy link

coveralls commented Dec 8, 2018

Coverage Status

Coverage decreased (-0.01%) to 94.664% when pulling 32dd241 on Alexmg86:hidden-text into af5a271 on PHPOffice:develop.

added unit test
docx reader
html reader/writer
odt writer
updated samples
@troosan troosan merged commit c2b54cc into PHPOffice:develop Dec 8, 2018
@troosan troosan added this to the v0.16.0 milestone Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants