-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add parsing of html image in base64 format #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
58c6c52
merged with local version
d54cc6e
fix lint
a228811
fixes
46b7bea
increased test coverage of new lines
a89e4c9
added exception control to file_get_contents error
65a594d
cs-fixer fixes
da604a8
use annotation instead
troosan c22f7ea
add check on opened file
troosan b2cafff
Merge remote-tracking branch 'upstream/develop' into develop_upstream
troosan e764871
update changelog
troosan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fopen() can return false if it fails to open the file.
see https://scrutinizer-ci.com/g/PHPOffice/PHPWord/inspections/1f0e808d-f874-4a64-9778-f459477f4d58/issues/files/src/PhpWord/Shared/Html.php?status=new&orderField=path&order=asc&honorSelectedPaths=0