Skip to content

Conversation

@WouterSioen
Copy link
Contributor

Description

This method call required both an array of writes and the filename, which was
missing in two method calls.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

I could not really check the last two items on the checklist since they are not really relevant.

This call requires both an array of writes and the filename, which was
missing in both method calls.
@WouterSioen
Copy link
Contributor Author

Build failure seems unrelated to my changes, do I re-push my commit to trigger a new build?

@troosan troosan merged commit c5d0f71 into PHPOffice:develop May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants