Skip to content

Adding setNumId method for ListItem style #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2019
Merged

Adding setNumId method for ListItem style #1329

merged 4 commits into from
Aug 8, 2019

Conversation

eweso
Copy link

@eweso eweso commented Mar 30, 2018

Description

By allowing to set the numId in the ListItem style manually, you can separate lists. Every ListItem with the same numId belongs to one list. This allows you to restart list counting. For example:

addListItem("tem 1", 0, ['listType' => 7, 'numId' => 1]);
addListItem("tem 2", 0, ['listType' => 7, 'numId' => 1]);
addListItem("tem 3", 0, ['listType' => 7, 'numId' => 1]);

// restart list
addListItem("item 1", 0, ['listType' => 7, 'numId' => 2]);
addListItem("tem 2", 0, ['listType' => 7, 'numId' => 2]);
addListItem("tem 3", 0, ['listType' => 7, 'numId' => 2]);

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

By allowing to set the numId in the ListItem style manually, you can separate lists. Every ListItem with the same numId belongs to one list. This allows you to restart list counting.
@eweso
Copy link
Author

eweso commented Mar 30, 2018

I have still problems in using GitHub. I hope, that my pull request now worked...

@troosan troosan added this to the v0.15.0 milestone May 31, 2018
@troosan troosan removed this from the v0.15.0 milestone Jul 14, 2018
@tobibuenter
Copy link

tobibuenter commented Jun 6, 2019

what's the state here? We have problems with restarting numbering levels (even "restart" => "newSection" is set)...

@troosan troosan added this to the v0.17.0 milestone Jun 13, 2019
@troosan troosan merged commit 85e9144 into PHPOffice:develop Aug 8, 2019
@eweso eweso deleted the patch-1 branch December 18, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants