-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Allow to set "autoHyphenation" setting #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
troosan
merged 24 commits into
PHPOffice:develop
from
Trainmaster:feature-allow-auto-hyphenation-setting
Mar 6, 2018
Merged
Changes from 8 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2b8d8ab
Allow to set "autoHyphenation" for document
Trainmaster 04d4f1a
Use guard clause
Trainmaster aaec196
Fix typos
Trainmaster 3f55ff9
Add missing boolean properties
Trainmaster 56c7c92
Allow to set "consecutiveHyphenLimit" for document
Trainmaster 566bf3b
Allow to set "hyphenationZone" for document
Trainmaster 406c712
Allow to set "doNotHyphenateCaps" for document
Trainmaster 762f40c
Allow to set "suppressAutoHyphens" for paragraph
Trainmaster 740e66a
randomize the tempDir more
troosan 30b224b
Word2007 parsing title formatting (#1297)
troosan 250fbd4
Added support for Vertically Raised or Lowered Text (w:position) (#1294)
troosan 321359a
Allow to set "autoHyphenation" for document
Trainmaster 363a6a4
Use guard clause
Trainmaster b73d275
Fix typos
Trainmaster 7759801
Add missing boolean properties
Trainmaster a13256d
Allow to set "consecutiveHyphenLimit" for document
Trainmaster 1084ca3
Allow to set "hyphenationZone" for document
Trainmaster 73d1f8d
Allow to set "doNotHyphenateCaps" for document
Trainmaster a71e9e5
Allow to set "suppressAutoHyphens" for paragraph
Trainmaster 38b5950
Merge branch 'feature-allow-auto-hyphenation-setting' of https://gith…
troosan 6947c43
fix typos
troosan ce70309
fix warning
troosan b00a2f2
fix unit test
troosan ec09372
add method to allow sorting of sections
troosan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@troosan Would you mind changing the phpcs
align_double_arrowsetting? Imho this is a good example what this rule can cause.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, it's more difficult to view what changed, but it's easier to read the code, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not always easier to read the code. Just think of one key with a very long name (
doNotUseMarginsForDrawingGridOriginin document settings, for example). This will cause a lot spaces which makes readability worse because tracking a line with many whitespaces can get exhausting,But like many other things it's also a matter of personal preference.