Multiple features and bug fixes

[gabrielbull]

Hello @Progi1984 @RomanSyroeshko @ivanlanin ,

I've received this by email, does anyone have the time to check out the code and see if it can be merged?

https://dl.dropboxusercontent.com/u/25609258/PHPWord.tar.gz

---

Please find enclosed my latest amendments to the PHPWord tree of files.

Basically I have done the following:

• Added Textboxes
• Added HTML input (you can write HTML and it will be converted to DOCX or ODT)
• Added absolute positioning of Images and Textboxes
• Repaired a bug in headers: if you add two headers within one section and both headers contain an Image, the resulting DOCX was corrupt
• Added multiple footers, such that a footer for the first page and a footer for the other pages can be defined.

In the next few weeks I am planning to do the following:

• Add list styles (numbering.xml for DOCX writer)
• Add special fields, such that you could add page numbers in the footer or header
• implement all the functionality in the ODT writer, which is now already present in the ( DOCX writer.

Please let me know if anything I have send you is helpful.
Regards,
Bas-Jan

[ivanlanin]

I did a quick check. I think this is from 0.8.

• Textbox: Good enhancement. Will explore more later.
• HTML input: Implemented by a new element type and transformed during writing. I'm not sure this is the right way to go. I'm thinking about parsing the HTML to existing elements (texts, titles, etc) directly when added.
• Absolute positioning: Good enhancement. Will explore more later.
• Bug in headers: Confirmed still exists.
• Multiple footers: We already have this feature.
• List styles: We already have this feature.
• Special fields: We already have PreserveText, although there's still room for improvement.
• Additional ODT Writer functionality: Good enhancement

[basjan]

Hi Gabriel and Ivan.
Thank you for taking the time to consider my code.
I think that the code is indeed based on 0.8 as it was a month ago the stable branch.
With regard to the HTML input. I also think that parsing it into existing elements would be the better, but more difficult, way. I did however desperately needed this kind of functionality and the quick solution was to directly convert the HTML into WordML.

[ivanlanin]

Thank you @basjan. Your enhancements are great.

Do you have time to port it to the current develop branch and request a pull? That way, you will be acknowledged as the author of that part of the code. I can do the porting but then the commit will be under my name.

[basjan]

@ivanlanin , I have never studied how to use Github properly (I only did download code), so I will first need to get some understanding howto develop and request a pull.

However, I understand, that there is a substantial gap between the branch I used and the development branch. I will continue to develop some further features (which I need for my internal company project), so I will learn to use GitHub.

The only thing is that next week I will be away and the week after I probably have to do some catching up for my day-time job. If it is no problem if I generate the pull request in the next few weeks, then I will do that. On the other hand, if you would like to incorporate this sooner, then you are welcome to generate the pull request yourself. I do not value mentioning my name much. I think it is much more important if good code is available to everyone.

I will let you know when I will catch up with the development branch and start porting my code. (probaly within the next two weeks)

[ivanlanin]

Take your time. It's necessary for us to have the original author credited properly. Let us know when you need any help.

[basjan]

OK. I will do that.

[basjan]

@gabrielbull I think that this issue may be closed. Most of the improvements I initially send you by email, are already merged in the development branch: #217, #219, #221, #222, #226, #228, #229.

Only the addHtml function has not been incorporated, but as @ivanlanin already mentioned it is better not to implement this functionality in the Writer part.
I took this at heart and am now coding a shared function, with which Html can be converted to objects. I expect to commit within the next few days.

[ivanlanin]

One important thing that we should note from your list of recommendation is the field element. It's now facilitated by PreserveText, but I think we need a more generic and flexible way of doing this.

[ivanlanin]

I close this issue because all recommendations have been created and merged into the develop branch. Thanks @basjan and @gabrielbull.