Skip to content
This repository was archived by the owner on Jan 2, 2019. It is now read-only.

removed double encoded html tags #410

Closed
wants to merge 4 commits into from
Closed

removed double encoded html tags #410

wants to merge 4 commits into from

Conversation

capile
Copy link

@capile capile commented Jul 25, 2014

The former line 1185: $cellData = htmlspecialchars($cellData); is double-encoding HTML tags when conditional colors are passed to the NumberFormat (like "0;[Red] 0"). The PHPExcel_Style_NumberFormat::formatColor callback, present in all occasions already encodes HTML content within the cell value (line 1408).

Also, there's a minor typo in the PHPExcel_Style_NumberFormat::ToFormattedString (the method uses a lowercase t).

@capile
Copy link
Author

capile commented Jul 25, 2014

Worth mentioning, this is a great project — I'd be glad to help if possible.

Thanks!

@capile
Copy link
Author

capile commented Aug 7, 2014

Still focusing the HTML Writer support, the styles generated are incompatible with the HTML structure used: at the style element you set column widths to col.colX while the table structure used td with the class as .columnX

Another issue: setting the td width has no apparently effect, leaving the HTML cells plainly different than the Excel or PDF versions — but if you switch it to min-width then you have a fully compatible layout. Both these updates are at the commit https://github.com/capile/PHPExcel/commit/4673d188fd0fdc9ab9ce9f75ddcde9f962528a34 available at this pull request.

Cheers,

Guilherme Capilé

@capile capile closed this by deleting the head repository Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants