Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP 6.5: account for new function polyfills #55

Merged
merged 1 commit into from
Apr 24, 2024
Merged

WP 6.5: account for new function polyfills #55

merged 1 commit into from
Apr 24, 2024

Conversation

swissspidy
Copy link
Contributor

WP 6.5 contains a polyfill for array_is_list, which was introduced in PHP 8.1.

Ticket: https://core.trac.wordpress.org/ticket/55105
Commit: https://core.trac.wordpress.org/changeset/57337

WP 6.5 contains a polyfill for `array_is_list`, which was introduced in PHP 8.1
@jrfnl
Copy link
Member

jrfnl commented Feb 5, 2024

Thanks @swissspidy ! I've labelled this PR as "wait for upstream" to merge it once WP 6.5 has been released/is close to release.

Note: While the PHP 8.0 functions are not yet flagged by the latest release of PHPCompatibility, they will be once PHPCompatibility 10.0 comes out.

As exclude-ing error codes which don't exist yet does not lead to errors in PHPCS, I'm fine with accepting this PR for the next 2.x release, along the same lines as previously done for PR #35.

@jrfnl
Copy link
Member

jrfnl commented Apr 24, 2024

WP 6.5 has been released in the mean time, so this is good to go.

@jrfnl jrfnl merged commit 27ae51f into PHPCompatibility:master Apr 24, 2024
5 checks passed
@swissspidy swissspidy deleted the add/wp65-polyfills branch April 24, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants