Sniff/isClassProperty: add unit tests covering multi-property definitions #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimg
reviewed
Mar 18, 2018
| // Multi-property declarations. | ||
| class MyClass { | ||
| /* Case 27 */ | ||
| public $varA = true; |
There was a problem hiding this comment.
Isn't this a typo ? Semi colon instead of comma ?
There was a problem hiding this comment.
Thanks for catching that. I've fixed up the original commit to change it to a comma.
jrfnl
force-pushed
the
feature/isClassProperty-additional-unit-tests
branch
from
ddf7c0d
to
286703a
Compare
…ions Verifies and safe-guards that multi-property definitions are handled correctly.
jrfnl
force-pushed
the
feature/isClassProperty-additional-unit-tests
branch
from
286703a
to
879b22d
Compare
|
Rebased to get the build to pass. (CS change in the mean time would interfere otherwise) |
wimg
approved these changes
Jun 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies and safe-guards that multi-property definitions are handled correctly.
Note: the build is currently not passing for the PHPCS check on the PHPCompatibility files because of a known upstream bug.See squizlabs/PHP_CodeSniffer#1898 and squizlabs/PHP_CodeSniffer#1899 for more details.
This is expected to be fixed soon.
The fix for the upstream issue has been merged, so the builds are passing again.