PHP 7.4 | Tokenizer/PHP: handle PHP tag at end of file consistently #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to PHP 7.4, a PHP open tag at the end of a file was not tokenized correctly in PHP itself. From the PHP 7.4 changelog: > `<?php` at the end of the file (without trailing newline) will now be > interpreted as an opening PHP tag. Previously it was interpreted either as > `<? php` and resulted in a syntax error (with short_open_tag=1) or was > interpreted as a literal `<?php` string (with short_open_tag=0). This commit makes the tokenization of PHP open tags at the end of a file consistent in all PHP versions. Includes tests. Includes adding a few extra test builds which test with `short_open_tag=On` for various PHP versions. Refs: * https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.core.php-tag * https://github.com/php/php-src/blob/30de357fa14480468132bbc22a272aeb91789ba8/UPGRADING#L37-L40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to PHP 7.4, a PHP open tag at the end of a file was not tokenized correctly in PHP itself.
From the PHP 7.4 changelog:
This commit makes the tokenization of PHP open tags at the end of a file consistent in all PHP versions.
Includes tests.
Includes adding a few extra test builds which test with
short_open_tag=Onfor various PHP versions.Refs:
Suggested changelog entry
Tokenizer/PHP: a PHP open tag at the very end of a file will now always be tokenized as
T_OPEN_TAG, independently of the PHP version.