Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generators/Generator: minor tweak #686

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 15, 2024

Description

  • Predefine the find/replace values as these don't change within the loop.
  • Only call str_replace() once with arrays for find/replace.

Suggested changelog entry

N/A

Related issues/external references

This PR is part of a series of PRs which will add a complete set of tests for the Generator feature.

In this case, the code in this PR is covered by the tests added in #671.

* Predefine the find/replace values as these don't change within the loop.
* Only call `str_replace()` once with arrays for find/replace.
@jrfnl jrfnl added this to the 3.11.1 milestone Nov 15, 2024
@jrfnl jrfnl merged commit 56784f1 into master Nov 15, 2024
72 checks passed
@jrfnl jrfnl deleted the feature/generator-minor-tweak branch November 15, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant