GH Actions: provide attestations for release PHAR files #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub has released a new feature called Artifact Attestations, which allows for verifying the integrity of artifacts build via GitHub Actions.
This is an additional security and compliance feature, which allows for checking which workflow build the artifact and ensuring the artifact has not been tampered with after the generation via the workflow.
To me, this sounds like a good addition to the build process for release phars, so this commit implements attesting PHARS for releases.
To verify the phar files (after the next release, which will be the first to use this feature):
* Download the PHAR file(s), either from "Releases", from the tag "Test" workflow run or via PHIVE.
* If downloaded as a zipped artifact, unzip to get to the actual PHAR files.
* Using the GitHub CLI tool, run the below command to verify:
```bash
gh attestation verify phpcs.phar -o PHPCSStandards
gh attestation verify phpcbf.phar -o PHPCSStandards
```
References:
* https://github.blog/changelog/2024-06-25-artifact-attestations-is-generally-available/
* https://docs.github.com/en/actions/security-guides/using-artifact-attestations-to-establish-provenance-for-builds
* https://github.com/actions/attest-build-provenance
* https://cli.github.com/
* https://github.com/cli/cli
jrfnl
force-pushed
the
feature/ghactions-attest-phars-for-tags
branch
from
927d93a
to
51e7828
Compare
|
Rebased without changes. Merging once the build has passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub has released a new feature called Artifact Attestations, which allows for verifying the integrity of artifacts build via GitHub Actions.
This is an additional security and compliance feature, which allows for checking which workflow build the artifact and ensuring the artifact has not been tampered with after the generation via the workflow.
To me, this sounds like a good addition to the build process for release phars, so this commit implements attesting PHARs for releases.
To verify the phar files (after the next release, which will be the first to use this feature):
Note: I've tested this by (temporary) commenting out the "releases only" condition and have succeeded in verifying the generated artifacts using the above steps.
References:
Suggested changelog entry
gh attestation verify [phpcs|phpcbf].phar -o PHPCSStandardsNote: this should probably also be mentioned in the README.