Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoloader: fix missing return value #479

Merged
merged 1 commit into from
May 6, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented May 6, 2024

Description

An autoloader should always return a boolean value to indicate whether or not it has loaded a file. This allows for chaining autoloaders.

In most cases, the return statement in the autoloader already returned a boolean, this was the only exception.

Suggested changelog entry

N/A

An autoloader should always return a boolean value to indicate whether or not it has loaded a file. This allows for chaining autoloaders.

In most cases, the `return` statement in the autoloader already returned a boolean, this was the only exception.
@jrfnl jrfnl added this to the 3.10.0 milestone May 6, 2024
@jrfnl jrfnl enabled auto-merge May 6, 2024 02:28
@jrfnl jrfnl merged commit 4abcf57 into master May 6, 2024
50 checks passed
@jrfnl jrfnl deleted the feature/autoload-consistent-return-value branch May 6, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant